diegocr / CleanLinks

Converts obfuscated/nested links to genuine clean links.
166 stars 45 forks source link

clicking on images in yahoo image search doesnt work #140

Open elypter opened 8 years ago

elypter commented 8 years ago

for example this url https://images.search.yahoo.com/yhs/search?p=tomatoes&norw=1&ei=UTF-8&type=__alt__ddc_linuxmint_com&fr=yhs-ddc-linuxmint&fr2=sp-qrw-corr-top&ri=4&hsimp=yhs-linuxmint&hspart=ddc&tab=organic&ri=4

yahoo also has a lot of rubbish in the url

geokis commented 8 years ago

Your e.g. link does not look it would tracks you. It only contains some system specific information.

If you want to clean it a little bit, try:

type\w*|tab\w*|hsimp\w*|fr\w*|hspart\w*

short:

(?:type|tab|hsimp|fr|hspart)\w*

But type and tab are widely used, so it can cause some problems with other sites.

The problem is that CleanLinks can not contain & or =in the match-settings. I am not sure why but CL is not supported the complete regex syntax. Maybe @diegocr can tell us more about it.


Btw: For me a yahoo image search Link looks like this:

https://images.search.yahoo.com/search/images;_ylt=AwrB8pEqzbFXgk8AzOCLuLkF;_ylc=X1MDOTYwNTc0ODMEX3IDMgRiY2sDYjRhYzV2OWJyM2ozbiUyNmIlM0QzJTI2cyUzRHRqBGZyAwRncHJpZAMzRlpMdi5aMVJKNjJjTHdlTGE1WGNBBG10ZXN0aWQDbnVsbARuX3N1Z2cDMTAEb3JpZ2luA2ltYWdlcy5zZWFyY2gueWFob28uY29tBHBvcwMwBHBxc3RyAwRwcXN0cmwDBHFzdHJsAzYEcXVlcnkDdG9tYXRlBHRfc3RtcAMxNDcxMjcwMTkwBHZ0ZXN0aWQDbnVsbA--?gprid=3FZLv.Z1RJ62cLweLa5XcA&pvid=xzGIJjY5LjGyKYX6V7HMdw0tODcuNwAAAADI0r2I&fr2=sb-top-images.search.yahoo.com&p=tomate&ei=UTF-8&iscqry=&fr=sfp

To clean:

_yl\w*\w*|gprid\w*|pvid\w*

or _yl\w*\w*|\w*id\w*

as group:

(?:_yl\w*|gprid|pvid)\w*

or (?:_yl\w*|\w*id)\w*

I noticed that *`\wid`** caused to often problems with other sites.

elypter commented 8 years ago

thanks