search

diegocr / CleanLinks

Converts obfuscated/nested links to genuine clean links.
166 stars 45 forks source link

Not working anymore... #153

Open Greenpassion opened 8 years ago

Greenpassion commented 8 years ago

Firefox 48.0.2 / 64 / Multitask Not working anymore... Is it the 64 version or the multitask enabled? Thanks

alekksander commented 8 years ago

no e10 here, but extension doesn't work on 48.0.2

geokis commented 8 years ago

No idea what you are talking about...

Firefox 48.0.2 x64 It is working at its best !

alekksander commented 8 years ago

sometimes it works… for example it's not possible to log in to aliexpress without adding it to the white list… but when i go to link from google, first it gives me: https://www.google.pl/url?sa=t&rct=j&q=&esrc=s&source=web&cd=13&ved=0ahUKEwiNyfqTipHPAhUJtxQKHVG6CvsQFghPMAw&url=https%3A%2F%2Fpl.wikipedia.org%2Fwiki%2FGrafika&usg=AFQjCNFmav2s9SazINQyZYOYlr2sVfNJmA&sig2=No-H5QAa6UY9rk_A6uKfYg&cad=rja and then redirects to: https://pl.wikipedia.org/wiki/Grafika Needless to say, links do not turn yellow (default highlight style [background:rgba(252,252,0,0.6); color: #000])

Greenpassion commented 8 years ago

Still not working... Removed and installed again...no results... Firefox 48.0.2 / 64 / MULTITASK

geokis commented 8 years ago

Come on guys... Deactivate the experimental multiPROCESS option and the problem is gone...

See also #120

alekksander commented 8 years ago

please read carefully! i do not use multiprocess! that is: Multiprocess Windows 0/1 (Disabled)

alekksander commented 8 years ago

okay so i re-added button to the toolbar… and it worked again! removing the icon disables this extension. Filled out issue: https://github.com/diegocr/CleanLinks/issues/154

Greenpassion commented 8 years ago

Ok! So I disabled the multiPROCESS thing and it went back to normality... Thanks a lot!

Korpip commented 8 years ago

Adding the icon allowed the addon to work for me as well on Firefox 49.0.1.

jawz101 commented 8 years ago

@geokis multiprocess isn't experimental anymore. It's in the stable release of Firefox. The fact it's being staged is because many add-on developers haven't made their add-ons multiprocess aware.

diegocr commented 8 years ago

fwiw, in August i did started porting CL to be fully e10s compatible to an state that it's currently functional, however once it was made compatible i did realized an unfortunate fact, Firefox is unable to properly unload frame-scripts and any modules loaded through them, turning re-startless extensions into requiring a restart between upgrades, which is quite odd.

GitCurious commented 8 years ago

Does that mean the e10s compatible build actually works - but it just means that a restart is needed to upgrade to a new version ?

Can we voluntarily "Beta Test" the working version anyway ?

(I have never understood the necessity or desire for restartless addons, I always restart after installing anything new anyway)

diegocr commented 8 years ago

Yes, that is what it means.

I can push what i've done till now, but first i need to clean up the code a bit, since is full of debugging stuff i've added while trying to deal with that.

piejanssens commented 8 years ago

What's up with e10s support, having to restart is really no issue comparing to not being compatible at all..

MikeZeDev commented 7 years ago

Any news on this? Having to restart is not a major problem and, maybe i am wrong but, not related to e10s validation

Quantum00 commented 7 years ago

I agree with piejanssens and MikeZeDev. Even if it needs a restart we still need it.

alekksander commented 7 years ago

yes, please fix, it's getting urgent.

jawz101 commented 7 years ago

Fwiw if it has to be e10s people can use Pure URL add-on. I think it does the same thing as this one

alekksander commented 7 years ago

unfortunately it does not.