search

diegocr / CleanLinks

Converts obfuscated/nested links to genuine clean links.
163 stars 45 forks source link

CleanLinks stops working if icon is removed from toolbar #164

Open Valentin-N opened 7 years ago

Valentin-N commented 7 years ago

As mentioned in https://github.com/diegocr/CleanLinks/issues/122 it seems that Reddit's links are not being cleaned. More details on how Reddit links are implemented can be found here (and a sample Greasemonkey script to clean them): https://www.reddit.com/r/privacy/comments/4aqdg0/reddit_started_tracking_the_links_we_click_heres/

I use Clean Links 2.7.1 and was able to capture this link: https://out.reddit.com/t3_5duofu?url=http%3A%2F%2Fnewcenturytimes.com%2F2016%2F11%2F19%2Fstop-being-played-america-watch-how-trumps-hamilton-tweet-distracts-from-his-fraud-case%2F&token=AQAA5-MxWCBEggxIoWFttoar5hRT42Pws49abB7dSfnihrxkDq_l&app_name=reddit.com

Which then points to: http://newcenturytimes.com/2016/11/19/stop-being-played-america-watch-how-trumps-hamilton-tweet-distracts-from-his-fraud-case/

Disclaimer: the link is just an example that I was able to observe and manually copy and does not represent my views on anything :)

andreacc commented 7 years ago

That link you posted was cleaned for me.

You probably added out.reddit.com to your exceptions.

Enter on your addons page, on Clean Links options, and on the field of "skip Domains" delete the entry for out.reddit.com.

Valentin-N commented 7 years ago

I have not touched the default exceptions list. Below is a copy of the domains in that list:

accounts.google.com,docs.google.com,translate.google.com,login.live.com,plus.google.com,www.facebook.com,twitter.com,static.ak.facebook.com,www.linkedin.com,www.virustotal.com,account.live.com,admin.brightcove.com,www.mywot.com,webcache.googleusercontent.com,web.archive.org,accounts.youtube.com,signin.ebay.com

Valentin-N commented 7 years ago

My problem seems to be related to https://github.com/diegocr/CleanLinks/issues/154 where I have removed the icon and this causes the addon to stop working. If I re-add the icon back the link seems to be sanitized. As https://github.com/diegocr/CleanLinks/issues/154 is closed, I will keep this issue open to track this problem.

alekksander commented 7 years ago

i closed it, because it is already fixed in commits, but not released as a version yet. to get it fixed You can download files from git, put (and overwrite) it inside .xpi of clean links and reinstall extension from this modified .xpi. if You stumble across any problems i could prepare such .xpi for You. cheers!