Use octicon for plus sign

[LouCypher]

Preview:

Doesn't look much different but at least it matches with other buttons.

If you prefer other icon — beer, for example — see https://github.com/styleguide/css/7.0

[jerone]

+1. Wouldn't a styled Firefox icon be better...

[LouCypher]

or add-on icon (green puzzle piece), since this extension also works on Seamonkey, Palemoon, etc. It is possible, but it's better to use octicon, IMHO.

[diegocr]

Nice idea(s) :-) we may could even make it configurable.

LouCypher, I don't like the use of innerHTML, so if you would like to change it i'll merge your PR, otherwise i could do it myself if you want.

[jerone]

or add-on icon (green puzzle piece)...

Even better!

[LouCypher]

I don't like the use of innerHTML, so if you would like to change it i'll merge your PR, otherwise i could do it myself if you want.

Done

[LouCypher]

Maybe add primary class (see CSS styleguide) to the button to make it green like AMO's install button?

What do you think?

[diegocr]

That looks nice.

Btw, i didn't merged your PR yet because there are merge conflicts and i'm busy atm working on something else, if you want to fix that yourself it'll be great :)

[Noitidart]

i like the simple firefox stylized icon. but its no big deal haha. i think the simple plain colored ff icon matches git style. i dont think it should match amo style cuz its not amo.

[Noitidart]

not using innerHTML is good because if we do AMO approvers reject it lol

[diegocr]

I was wondering if the green button might lead to confusion, you know on AMO this is used for fully approved add-ons, so there might be someone thinking it's safe to install extensions straight from repos? I've just added it to the button in PRs in any case...

[Noitidart]

if you want to use proper color coding probably the unapproved color:

<a class="button  caution prominent  add" data-hash="sha256:c361e73d76a876b195127a4c0ab8804aa231d575e2379364c0dfd0684ed11091" href="https://addons.mozilla.org/firefox/downloads/file/243892/nthotkey-1.1-fx.xpi?src=dp-btn-primary">
      <b></b>
    <span>Add to Firefox</span>
  </a>

i still prefer the simple stylized ff icon, it matches git style

[diegocr]

That "unapproved" one is already being used when clicking the button. Although i think i can just change that by any standard style as provided by Lou.

Edit: Yeah, it looks more nice now 38865b5a1d42d8a5e8a1405e654e6b53caba92f9 :-)

[jerone]

Edit: Yeah, it looks more nice now 38865b5 :-)

Looking good!

Maybe changing the annoying alert messages in something more elegant would be great too...

[diegocr]

Heh, well... that helped me during development since the generated XPI isn't removed from temp until it's closed, but yeah... i'll make that configurable.

[LouCypher]

Sorry for the late reply, and thanks for the commits.

I was wondering if the green button might lead to confusion, you know on AMO this is used for fully approved add-ons, so there might be someone thinking it's safe to install extensions straight from repos?

Good thinking.

38865b5 7afce70

Looks even better now :heart_eyes:

Cheers :beers:

[diegocr]

No problem, thank you for the helpful resources and ideas :+1: