diegocr / GitHubExtIns

Install Browser Extensions straight from GitHub Repositories.
108 stars 65 forks source link

Cannot install SDK addons #9

Open Noitidart opened 10 years ago

Noitidart commented 10 years ago

Tons of new kids are using the sdk and posting it onto github. The official sdk site has this as an official example: Annotator - SDK Official

However I can't install it because these suckers don't have install.rdf's. Please make compatible.

diegocr commented 10 years ago

Heh.... take a look:

http://ask.mozilla.org/question/199/how-would-you-package-a-sdk-based-add-on-without-using-the-sdkpython/

As you can see, i posted that more than a week ago and didn't get a reply yet on how to do that....

For everyone looking for this feature, feel free to show your interest in that thread at ask.m.o

Noitidart commented 10 years ago

I think from FF30 sdk is now packaged with the browser. Maybe we can revisit this issue.

Noitidart commented 10 years ago

Aw shoot accidentally closed. Re-opening.

Noitidart commented 8 years ago

I think now that we are revisiting, due to the signing, and the change in template. We should seriously consider SDK addon ability. Almost all addons now are SDK. Just food for thought :)

We can import and use the jpm npm module like this - taken from - https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/system_child_process#Using_child_process_in_non-jpm_extensions -

// Import SDK Stuff
const COMMONJS_URI = 'resource://gre/modules/commonjs';
const { require } = Cu.import(COMMONJS_URI + '/toolkit/require.js', {});
var child_process = require('sdk/system/child_process');

// Use it in the same way as in the example above
Noitidart commented 8 years ago

Hey @diegocr I was wondering if there any blocking issues preventing us from landing building xpi from jpm addons? cfx has been deprecated and AMO does't accept it.

So all we would have to do is add what jpm xpi does which is this:

https://github.com/mozilla-jetpack/jpm/blob/master/lib/xpi.js

Would this be possible?