diegodario88 / quake-terminal

Gnome Shell extesion to launch a terminal in quake mode
GNU General Public License v3.0
40 stars 6 forks source link

Remove chance for race condition #16

Closed freimair closed 8 months ago

freimair commented 8 months ago

Currently, the request for opening a new terminal window is issued before the app-windows-changed signal handler is set up. Depending on backend implementation, system state, or pure chance, there is a chance of missing the event and thus, getting the extension stuck in an unrecoverable state.

Requesting a new window after the handler is set up does prevent missing the event.

Does not seem to cause an issue in single-terminal mode, however, as I pushed the project towards one terminal per workspace, erratic behavior started to show up - and I tracked it down to this.

diegodario88 commented 8 months ago

Thanks @freimair