Add "Show on the primary Display" and "Show on the current Display" preferences

diegodario88 / quake-terminal

Gnome Shell extesion to launch a terminal in quake mode

GNU General Public License v3.0

40 stars 6 forks source link

Add "Show on the primary Display" and "Show on the current Display" preferences #20

Closed petre2dor closed 8 months ago

petre2dor commented 8 months ago

@diegodario88 sorry for adding a bunch of commits in this PR. I did not know that this will happen when I pushed to my main. As you can see, this PR is work in progress and it needs some cleanup. It works quite nicely, with the exception of some weird animations that makes it look like the terminal is being move from another monitor. I will look into that whenever I get a bit of time.

Of course, any review or feedback is appreciated.

Cheers!

petre2dor commented 8 months ago

@diegodario88 this PR is ready for review and testing now

Henry78 commented 8 months ago

LGTM (https://github.com/diegodario88/quake-terminal/issues/15#issuecomment-1803408217)