feat: update Quake Terminal preferences

diegodario88 / quake-terminal

Gnome Shell extesion to launch a terminal in quake mode

GNU General Public License v3.0

40 stars 6 forks source link

feat: update Quake Terminal preferences #22

Closed diegodario88 closed 8 months ago

diegodario88 commented 8 months ago

Added functionality to select the terminal application in the preferences.
Users can now choose their preferred terminal emulator from a list of available options.
The selected terminal application ID is stored in the settings.
The selected terminal application ID is displayed in the preferences UI.
Added an icon and help button to provide information about the selected terminal application.
Updated the help dialog to include relevant information about setting up the terminal application.

This commit adds the ability for users to customize their terminal experience by selecting their preferred terminal application.

petre2dor commented 8 months ago

@diegodario88 hey, it does not seem to be working for me. Nothing is happening for me when I click the Terminal Application row.

JS ERROR: TypeError: app.get_categories() is null
fillPreferencesWindow/</selectableApps<@file:///home/petre/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/prefs.js:241:17
fillPreferencesWindow/<@file:///home/petre/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/prefs.js:230:6
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

Screencast from 2023-11-18 22-59-00.webm

I'll dig around for a bit longer to find out which app does not have categories.

petre2dor commented 8 months ago

@diegodario88 overall, I would prefer this extension to be usable for any application, as some users might want to use it for chat or notes or whatever. Would you entertain the idea of allowing users to select any app?

I'll do a bit more testing tomorrow. Thanks for the enhancement, it's really nice to have :+1:

diegodario88 commented 7 months ago

@diegodario88 hey, it does not seem to be working for me. Nothing is happening for me when I click the Terminal Application row.
JS ERROR: TypeError: app.get_categories() is null
fillPreferencesWindow/</selectableApps<@file:///home/petre/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/prefs.js:241:17
fillPreferencesWindow/<@file:///home/petre/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/prefs.js:230:6
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
Screencast.from.2023-11-18.22-59-00.webm I'll dig around for a bit longer to find out which app does not have categories.

Thanks for flagging the issue!

diegodario88 commented 7 months ago

@diegodario88 overall, I would prefer this extension to be usable for any application, as some users might want to use it for chat or notes or whatever. Would you entertain the idea of allowing users to select any app?

I'll do a bit more testing tomorrow. Thanks for the enhancement, it's really nice to have 👍

I'm open to the idea of making the extension usable for any application, and I appreciate your feedback! However, it's essential to note that the initial focus was on terminal emulators, and there might be unforeseen issues with other windows that are beyond our current scope. I'm glad you find the enhancement useful.

petre2dor commented 7 months ago

I tested a bit more and everything looks good.

As for allowing any application, I think a good start would be add a checkbox "Show all applications" with a warning that informs the user that they might encounter issues and that the extension officially supports only Terminal applications.