fix: check if categories are null when filtering applications

diegodario88 / quake-terminal

Gnome Shell extesion to launch a terminal in quake mode

GNU General Public License v3.0

40 stars 6 forks source link

fix: check if categories are null when filtering applications #23

Closed petre2dor closed 7 months ago

petre2dor commented 8 months ago

fix for #22

seems like a documentation error because get_categories() can return null, but the docs mention only string: https://gjs-docs.gnome.org/gio20~2.0/gio.desktopappinfo#method-get_categories

petre2dor commented 7 months ago

@diegodario88 please consider merging this PR. The currently released version is not allowing me to select any terminal app because of this bug. Cheers!

diegodario88 commented 7 months ago

@diegodario88 please consider merging this PR. The currently released version is not allowing me to select any terminal app because of this bug. Cheers!

Hi @petre2dor, looking forward to hearing your thoughts on the review above so I can merge this

petre2dor commented 7 months ago

sorry @diegodario88 I don't see any review on this PR. Am I blind?

diegodario88 commented 7 months ago

sorry @diegodario88 I don't see any review on this PR. Am I blind?

My bad, I forgot to publish it 😔