search

diegodario88 / quake-terminal

Gnome Shell extesion to launch a terminal in quake mode
GNU General Public License v3.0
51 stars 6 forks source link

Settings are not available after installation #24

Closed M0Rf30 closed 10 months ago

M0Rf30 commented 10 months ago

Thanks for this fork, I installed it on arch linux with gnome 45.1 going on extensions.gnome.org and when I click on settings this stacktrace appears:

TypeError: app is null

Stack trace:
  getAppIconImage@file:///home/user/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/prefs.js:53:24
  fillPreferencesWindow@file:///home/user/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/prefs.js:175:34
  _loadPrefs@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:36:18
  async*_init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:21:14
  ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:12:4
  OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:139:33
  async*_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
  _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
petre2dor commented 10 months ago

Hi @M0Rf30,

Do you also see in the log something like this before this error? Unable to locate a terminal application with the specified ID... Can you please paste that hole line here?

Thanks!

petre2dor commented 10 months ago

Looks like you don't have the Gnome default terminal app installed: org.gnome.Terminal.desktop

I am going to push a PR to allow this case and it will look something like this:

image

petre2dor commented 10 months ago

@M0Rf30 Please test my PR if you can #25. You can clone my fork and follow the Setup instructions from Readme.

M0Rf30 commented 10 months ago

@M0Rf30 Please test my PR if you can #25. You can clone my fork and follow the Setup instructions from Readme.

Yeah it works flawlessly, allowing me to choose a terminal program