Timeout when opening kitty on Wayland

TiagodePAlves commented 3 months ago

I've been using kitty recently and it is a bit slower at startup (but faster when running) and it actually triggers the 1 second timeout. Here are the logs:

abr 13 23:11:14 marmis-arch gnome-shell[1160]: Error: Timeout reached when attempting to open quake terminal
                                               timeoutHandler@file:///home/marmis/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/util.js:119:26
                                               @resource:///org/gnome/shell/ui/init.js:21:20

abr 13 23:11:14 marmis-arch gnome-shell[1160]: Source ID 3153 was not found when attempting to remove it
abr 13 23:11:15 marmis-arch gnome-shell[1160]: g_source_remove: assertion 'tag > 0' failed
abr 13 23:11:15 marmis-arch gnome-shell[1160]: JS ERROR: TypeError: this._terminal is null
                                               shellAppWindowsChangedHandler@file:///home/marmis/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/quake-mode.js:226:10
                                               signalOnceHandler@file:///home/marmis/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/util.js:96:10
                                               SignalConnector/this.id<@file:///home/marmis/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/util.js:32:54
                                               @resource:///org/gnome/shell/ui/init.js:21:20
abr 13 23:11:15 marmis-arch gnome-shell[1160]: Invalid window geometry for xdg_surface@29. Ignoring for now, but this will result in client termination in the future.

In the logs, we can also see a TypeError, raised when the function shellAppWindowsChangedHandler tries to access this._terminal after the timeout happened and the terminal was set to null.

The main problem for me, though, is using STARTUP_TIMER_IN_SECONDS as just one second. This timeout used to be 5 seconds up until last October, but it was reduced in 9c3e710. Is there a reason for this? I believe the startup limit time should be increased again, even the promise name suggests this should be five seconds: promiseTerminalWindowInLessThanFiveSeconds.

System Information

cat ~/.local/share/gnome-shell/extensions/quake-terminal@diegodario88.github.io/metadata.json

```json { "_generated": "Generated by SweetTooth, do not edit", "description": "Quickly launch a terminal in Quake mode using a keyboard shortcut", "donations": { "github": "diegodario88", "kofi": "diegodario" }, "name": "Quake Terminal", "settings-schema": "org.gnome.shell.extensions.quake-terminal", "shell-version": [ "45", "46" ], "url": "https://github.com/diegodario88/quake-terminal", "uuid": "quake-terminal@diegodario88.github.io", "version": 19, "version-name": "1.6.2" } ```

inxi -Fxz

```raw System: Kernel: 6.8.5-arch1-1 arch: x86_64 bits: 64 compiler: gcc v: 13.2.1 Desktop: GNOME v: 46.0 Distro: Arch Linux Machine: Type: Desktop Mobo: ASRock model: B450M Steel Legend serial: UEFI: American Megatrends v: P10.08 date: 01/19/2024 Battery: [...] CPU: Info: quad core model: AMD Ryzen 5 1500X bits: 64 type: MT MCP arch: Zen rev: 1 cache: L1: 384 KiB L2: 2 MiB L3: 16 MiB Speed (MHz): avg: 2435 high: 3600 min/max: 1550/3500 boost: enabled cores: 1: 3482 2: 3368 3: 1377 4: 1378 5: 3520 6: 3600 7: 1378 8: 1378 bogomips: 56031 Flags: avx avx2 ht lm nx pae sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3 svm Graphics: Device-1: NVIDIA GM206 [GeForce GTX 960] vendor: eVga.com. driver: nvidia v: 550.67 arch: Maxwell bus-ID: 07:00.0 Display: wayland server: X.org v: 1.21.1.13 with: Xwayland v: 23.2.6 compositor: gnome-shell driver: gpu: nvidia,nvidia-nvswitch resolution: no compositor data resolution: 1920x1080 API: EGL v: 1.5 drivers: nvidia,swrast,zink platforms: active: gbm,wayland,x11,surfaceless,device inactive: device-1 API: OpenGL v: 4.6.0 compat-v: 4.5 vendor: nvidia mesa v: 550.67 glx-v: 1.4 direct-render: yes renderer: NVIDIA GeForce GTX 960/PCIe/SSE2 API: Vulkan v: 1.3.279 drivers: nvidia surfaces: xcb,xlib,wayland devices: 1 Audio: [...] Network: Device-1: Realtek RTL8111/8168/8211/8411 PCI Express Gigabit Ethernet vendor: ASRock driver: r8169 v: kernel port: f000 bus-ID: 05:00.0 IF: enp5s0 state: up speed: 1000 Mbps duplex: full mac: Drives: Local Storage: total: 465.76 GiB used: 26.92 GiB (5.8%) ID-1: /dev/nvme0n1 vendor: Kingston model: SA2000M8500G size: 465.76 GiB temp: 36.9 C Partition: ID-1: / size: 453.86 GiB used: 26.65 GiB (5.9%) fs: ext4 dev: /dev/nvme0n1p3 Swap: ID-1: swap-1 type: partition size: 8 GiB used: 0 KiB (0.0%) dev: /dev/nvme0n1p2 Sensors: [...] Info: Memory: total: 16 GiB available: 15.55 GiB used: 4.27 GiB (27.5%) Processes: 296 Uptime: 30m Init: systemd Packages: 1128 Compilers: clang: 17.0.6 gcc: 13.2.1 Shell: fish v: 3.7.1 inxi: 3.3.33 ```

kitty --version

```raw kitty 0.33.1 created by Kovid Goyal ```

diegodario88 commented 3 months ago

Hey Tiago, thank you for bringing this up. Indeed, the timeout must be five seconds

diegodario88 commented 3 months ago

I'm going to close this for now, but please feel free to reopen it anytime. Once we've finished investigating the kitty issue, I'll update and submit a new version to GNOME Extensions.

diegodario88 / quake-terminal

Timeout when opening kitty on Wayland #31

System Information