diegodario88 / quake-terminal

Gnome Shell extesion to launch a terminal in quake mode
GNU General Public License v3.0
54 stars 6 forks source link

Exploring the Functionality of a Close Button for Animation Conflicts #41

Open SJFCS opened 1 month ago

SJFCS commented 1 month ago

Terminal wake-up animation conflicts with compiz-alike-magic-lamp-effect extended settings. This results in a two-blink animation. Is this possible to provide an animated close button to use the system global animation settings?

diegodario88 commented 1 month ago

Thanks for pointing this out! Just to clarify—when you mention the close animation, are you referring to the terminal’s "wake-up" or open animation conflicting with the compiz-alike-magic-lamp-effect, or are you specifically asking about adding an animated close button?

SJFCS commented 1 month ago

Thanks for pointing this out! Just to clarify—when you mention the close animation, are you referring to the terminal’s "wake-up" or open animation conflicting with the compiz-alike-magic-lamp-effect, or are you specifically asking about adding an animated close button?

Thank you for your prompt reply If possible I would like to have a button to turn off the animation. would you adding an animated close button?

diegodario88 commented 1 month ago

would you adding an animated close button?

I think that's out of the scope of this project.

SJFCS commented 1 month ago

would you adding an animated close button?

I think that's out of the scope of this project.

I mean set a button to turnoff the terminal popup animation of the project itself here: https://github.com/diegodario88/quake-terminal/blob/189f2a892ecf17cac79bf24da33d87834933daef/quake-terminal%40diegodario88.github.io/quake-mode.js#L169-L184

diegodario88 commented 1 month ago

I understand. That is achievable if someone is willing to put in the effort. I would be happy to review it.