Closed jrmarqueshd closed 2 years ago
Please solve this issue and make it backward compatible, blocking our execution.
For temporary solution -:
Go to - node_modules/react-redux-toastr/src/styles/index.scss
Instead of using math.div use division(/) or multiplication() i.e. css/2 or css0.5, such as
"margin-left: -($toastr-width / 2);"
+1
Hi guys, I believe next week there will be time for me to have a look at this issue.
This is a pretty critical error for our apps as well.
After looking at it, I can see that this was caused by a fix made for another issue, I made the mistake of changing the minor but it's actually a breaking change since the node-sass
was deprecated and sass
was added as the new dependencies.
My advice is that if possible upgrade sass
or rollback to v7.6.4
Hi all - I created the commit for bumping the dev-deps to sass
instead of the now deprecated node-sass
. There were some outstanding issues this was related to (referenced in #269) where the sass division changes were throwing some loud and angry warnings across newer apps.
I agree with @diegoddox doubly, that pinning to an older release is probably a good idea for users still using node-sass
. And the change over to the modern sass
dependency probably warrants a major version bump. Sorry for any issues!
@diegoddox -if there's any help i can provide on this please let me know!
Hello everyone!
For those who are having this error and want to solve it quickly:
In your package.json, change the version of the react-redux-toastr library from 7.6.6 to 7.6.5, the result should look something like this:
Note that, it is also necessary to remove any flags that have the package version together, as this will prevent the library from updating during the npm install and npm run build time.
After that, delete the node_modules folder and/or run an
npm install && npm run build
.For those responsible for the library:
Today, I noticed a bug happening inside react-redux-toastr/src/styles/index.scss, I use that file to style my notifications and import it into my styles root file.
I use the node-sass@6.0.1 package and I have a main.scss file where I call all the .scss styles from my application. I do the same for the styles that are inside node_modules/react-redux-toastr/src/styles/index.scss.
When the application runs normally, the problem occurs in the npm run build, where it displays the error:
My versions are:
I hope I helped in some way!