diegodlh / zotero-cita

Cita: a Wikidata addon for Zotero with citations metadata support
GNU General Public License v3.0
234 stars 12 forks source link

Not fetching QID #127

Closed jokroese closed 3 years ago

jokroese commented 3 years ago

Describe the bug Clicking 'Fetch QID(s)' opens a notification that says 'Cita [C]'. This notification stays around with no further information and the QID is never fetched.

To Reproduce

A notification pops up and does not change.

Expected behavior I expect the notification to say that it is fetching the QID and then the QID to appear in the QID section of citations.

Screenshots

Screenshot 2021-09-01 at 15 03 41

Environment:

Additional context The debug output log from running all steps to reproduce: cita_debug_output_log.txt

A more concise debug output log that assumes the item is already added (i.e. the log of just running 'Fetch QID(s)'): cita_debug_output_log_fetch_only.txt

miguelrochefort commented 3 years ago

Same problem here using Zotero 5.0.97-beta.43+c5d89f6d0.

diegodlh commented 3 years ago

Thank you both for reporting this! The bug was a result of some changes made to Zotero's beta channel. I've fixed it in master with 9a0bf00. I will try to release a new version of Cita including this soon.

If you find other bugs in Zotero beta I'd appreciate it if you could report them, so we make sure Cita is working when Zotero 6.0 is released.

diegodlh commented 3 years ago

Dear @joekroese and @miguelrochefort, I've just released Cita v0.3.0 including this fix. As other major changes have been included as well, I have marked it as pre-release and it isn't available for automatic update by Zotero yet. I plan to do this probably by the end of next week. In the mean time, I would appreciate it if you could help me giving it a try an making sure nothing broke by downloading it here. Thanks!

jokroese commented 3 years ago

Just tried out the pre-release and it's working! Thanks @diegodlh!

miguelrochefort commented 3 years ago

It's working for me too. Thanks for the quick fix!