diegodlh / zotero-cita

Cita: a Wikidata addon for Zotero with citations metadata support
GNU General Public License v3.0
233 stars 12 forks source link

Skip untyped query if fetching QID with `options.partial === false` #155

Closed Dominic-DallOsto closed 2 years ago

Dominic-DallOsto commented 2 years ago

Fixes #153

The logic is:

Dominic-DallOsto commented 2 years ago

This approach works nicely. The only annoyance I found in a few cases was that conference papers weren't getting matched to scholarly articles because Wikidata says their types are different. I'm not sure if it would make things too complicated, but it might be nice to also do an uptyped query and accept an untyped match if there's a DOI/ISBN match?

I think you mentioned this already in another issue, but some feedback saying "no exact matches were found - try getting QIDs of each item individually" would be nice.

Dominic-DallOsto commented 2 years ago

Selecting the only typed match could work badly - I found some examples with a single match with a score of only 20. It's better to only accept the direct match if the query response says it's a direct match. If not, it'll be listed as a partial match anyway for the user to accept.