search

diegodlh / zotero-cita

Cita: a Wikidata addon for Zotero with citations metadata support
GNU General Public License v3.0
234 stars 12 forks source link

Cycle through fields with tab in the citation editor (and others keybindings) #218

Open Futur3r opened 1 year ago

Futur3r commented 1 year ago

Is your feature request related to a problem? Please describe. If I need to contribute the references of an article manually, I need to do it quickly and easily.

Describe the solution you'd like The ability to 'cycle' through (i.e to change) fields like title, author first name, author last name, etc. with the TAB key (and go the inverse way with Maj+Tab). Also some simple keybindings (that could be eventually set in the preferences) to add/delete an author, open the type of author drop down (author, contributor, editor, ...), save the citation, add a new citation (i.e open another citation editor), change the type of item (journal article, book, book section, ...) and launch a query for it's QID if it exist. And the citation editor stays, by default, always on top !

Describe alternatives you've considered There is no alternative for now other than tedious clicking and window switching.

TLDR of functions to add to the citation editor:

PS: for the QID query, if it finds the element, the others fields of the editor are automatically completed and the editor save and close automatically

Futur3r commented 1 year ago

little link to #57 :)

Dominic-DallOsto commented 1 year ago

The tab key not working basically sounds like a bug that we should fix.

Do you have an example of an extension that has a nice keybinding system that we could base this off? If it's just confined to a few commands in the citation editor this should be easy enough to do ad-hoc. But to cover a lot of functionality I guess it'd be good to design things a bit more properly beforehand.

Is there an issue that the citation editor sometimes loses focus and disappears for you at the moment? Or is it just that it should stay on top once these new features are added?

Futur3r commented 1 year ago

For the keybindings, I do not have an extension example for the moment. But Zotero itself supports it, in the fields of an item.

And for the citation editor, it's more your second option, it should stay on top. By default the window should be configured to stay on top.

Dominic-DallOsto commented 1 year ago

The tab key not working is because of this line here. If I comment it out tabbing through the fields works nicely. Not exactly sure what the comment means / what the side effects of commenting out this line are.

https://github.com/diegodlh/zotero-cita/blob/master/src/dialogs/editor/CitationEditor.jsx#L35

Futur3r commented 1 year ago

I tested a bit, and it seems to have no problem. @diegodlh what do you think can this statement be put into a comment safely ?