search

diegodlh / zotero-cita

Cita: a Wikidata addon for Zotero with citations metadata support
GNU General Public License v3.0
233 stars 12 forks source link

Remove redundant call to initLocale()? #286

Closed diegodlh closed 2 months ago

diegodlh commented 3 months ago

Hi, @Dominic-DallOsto!

I found initLocale() was called twice in our code: once in src/hooks.ts and another in src/cita/zoteroOverlay.tsx.

I thought this might be redundant and tried to remove the call from src/cita/zoteroOverlay.tsx and translation seems to be working OK.

Because you have been more involved in this change than me, I thought I'd better ask you before merging this change into our zotero7 branch.

If you think it's OK to merge, please do! We can always roll back anyways, if needed :)

Thanks!

github-actions[bot] commented 2 months ago

:rocket: This ticket has been resolved in v1.0.0-beta.0. See Release 1.0.0-beta.0 for release notes.