search

diegodlh / zotero-cita

Cita: a Wikidata addon for Zotero with citations metadata support
GNU General Public License v3.0
233 stars 12 forks source link

QID is not saved if fetched immediately after erasing previous value #293

Closed diegodlh closed 2 months ago

diegodlh commented 2 months ago

Describe the bug If the QID of an item is fetched immediately after removing its previous QID value, then the new fetched QID is not correctly saved.

To Reproduce

  1. Select an item with a QID value.
  2. Erase the QID value in the Cita pane. Note that it is erased from the item's extra field in the Info pane too.
  3. Without changing the item selection, click to fetch the QID for the item from Wikidata.
  4. Select another item and then select the previous item again.

Expected behavior In 3. above, the fetched QID should be written to the QID field in the Cita pane. Instead, the field remains empty. Note that the fetched QID is written to the item's extra field in the Info pane.

In 4. above, after deselecting and selecting the item again, the QID fetched before should remain saved. Instead, it is lost. Both from the QID field in the Cita pane and from the extra field in the Info pane.

Environment:

Additional context I wonder whether this may be related in any way to #292, which also involves updating QID and other unique identifier fields in the Cita pane.

Dominic-DallOsto commented 2 months ago

I get the same as you after 3. the QID shows up in the info pane but not the Cita pane.

But after 4. the QID shows up in both the Info pane and Cita pane for me.

github-actions[bot] commented 2 months ago

:rocket: This ticket has been resolved in v1.0.0-beta.1. See Release 1.0.0-beta.1 for release notes.