search

diegogarciahuerta / tk-substancepainter

:moyai: Shotgun Toolkit Engine for Allegorithmic Substance Painter https://www.allegorithmic.com/products/substance-painter
Other
45 stars 37 forks source link

Support for the new versioning number system introduced in 2020.1->6.1 #9

Closed diegogarciahuerta closed 4 years ago

diegogarciahuerta commented 4 years ago

See #7 , a new versioning number system was introduced in 2020.1 -> 6.1.

New version system was introduced in version 2020.1, that became version 6.1.0, so we need to do some magic to normalize versions. https://docs.substance3d.com/spdoc/version-2020-1-6-1-0-194216357.html

The way we support this new version system is to use LooseVersion for version comparisons. We modify the major version if the version is higher than 2017.1.0 for the version to become in the style of 6.1, by literally subtracting 2014 to the major version component. This leaves us always with a predictable version system: 2.6.2 -> 2.6.2 (really old version) 2017.1 -> 3.1 2018.0 -> 4.0 2020.1 -> 6.1 (newer version system starts) 6.2 -> 6.2 ...

(2017.1.0 represents the first time the 2k style version was introduced)

MrDice commented 4 years ago

Thank you very much for this update! I plugged it into our custom pipeline configuration and can verify that it works. It lists Substance Painter 6.1.1. I'm able to launch it and open a file. I didn't test publishing because we have this customized at our end. I'm not able to verify that it still works with older versions of Substance Painter. Thanks again!

diegogarciahuerta commented 4 years ago

Awesome, thanks for testing, I see no issues with previous versions so I will go ahead and merge.