Production task PROOF: Proofread spelling, grammar, etc

santiagohermo commented 2 years ago

In this paper we will perform a general proofreading of the paper, including both the main text and the appendices.

We will implement task PROOF from the gslab manual.

Goals

Typos, spelling/grammar errors, unclear wording, etc. corrected (don’t forget to include table notes, figure notes, footnotes, axis labels, appendices, etc.)
Follow rules outlined in paper style guide
References to any sections of the paper or tables or figures check out, in the sense that the referenced object exists and seems to have the information promised by the reference
Titles of sections, tables, figures, etc. are clear, descriptive
Variable names, notation, and other concepts are used consistently; the same notation is never used to refer to two different things

If you feel like some sentence or idea could be worded better, flag that and propose an alternative.

Deliverables

A single pdf document with all changes/comments clearly marked using Adobe Acrobat’s commenting tools. Recurring issues are flagged individually only if requested by PIs per the preceding.
If you notice a recurring issue, comment in this issue asap, providing examples.

Relevant version of the paper: min_wage_rent.pdf

santiagohermo commented 2 years ago

Common typos to look for, from @santiagohermo's experience:

casual instead of causal
Usage of this instead of these
Inconsistent use of -, eg, "ZIP code-specific trend" and "ZIP code specific trend"
Treating multiple-author cites as if they were a single author, eg, "Cegniz et al (2019) shows" when it should be "Cegniz et al (2019) show"
Inconsistent use of title caps, eg, some subsection use it, some don't
Math symbols that are used more than once

santiagohermo commented 2 years ago

Juan Pereira agreed to read the paper for this task. I will send him the paper via email.

santiagohermo commented 2 years ago

We will use this branch to incorporate feedback from Jon Roth, Peter Hull, and Neil Thakral.

Here are comments from JR: min_wage_rent_JR.pdf

gabrieleborg commented 2 years ago

@santiagohermo I finished the proof read. I added few comments in the PDF here, and fixed a couple of typos in the latex files (also reported in the PDF)

min_wage_rent_GB_proof_read.pdf

santiagohermo commented 2 years ago

Comments by Juan Pereira: min_wage_rent_JP.pdf

santiagohermo commented 2 years ago

Grazie mile @gabrieleborg ! I will go through the changes as soon as I have some time.

diegogentilepassaro commented 2 years ago

@gabrieleborg thanks for noting that the sample of tab:heterogeneity was different. Fixed in ac00464. The changes in the table are below for reference:

In summary:

Now the baseline is the same as everywhere.
The heterogeneity results are stronger than with the slightly wrong sample.

santiagohermo commented 2 years ago

I collapsed the comments by @gabrieleborg and Juan Pereira in min_wage_rent_PROOF_GB_JP.pdf. I will go through them now.

santiagohermo commented 2 years ago

Note: branch updated from master

martingallardo23 commented 2 years ago

Small tip here: I think the "by c." in the appendix is a typo https://github.com/diegogentilepassaro/min_wage_rent/blob/dfaa2ea857e42125031c97a23529e139a51eb088/paper_slides/paper/appendix.tex#L175-L177

santiagohermo commented 2 years ago

Thanks @martingallardo23! Fixed in https://github.com/diegogentilepassaro/min_wage_rent/commit/c4718164a81b1507ed7239e0cc42fe1bc9368f6d.

santiagohermo commented 2 years ago

I replied to JR's comments and implemented changes in the commits above. Annotated PDF is min_wage_rent_JR_SH.pdf.

I compiled the paper in https://github.com/diegogentilepassaro/min_wage_rent/commit/71091cd6a904bff49c9c10f6d2d6c45ad82c3859. I will send it to Neil T so that he makes comments on a more updated version.

santiagohermo commented 2 years ago

fyi @diegogentilepassaro @gabrieleborg @martingallardo23

santiagohermo commented 2 years ago

Replies to @gabrieleborg and JP are in min_wage_rent_PROOF_GB_JP_SH.pdf. I forgot to upload them before!

Can you take a look @gabrieleborg and @diegogentilepassaro? I left some requests there I believe.

santiagohermo commented 2 years ago

In the commits above I implemented changes after a pass of PROOF.

Annotated pdf is min_wage_rent_SH.pdf
Compiled pdf is in https://github.com/diegogentilepassaro/min_wage_rent/commit/1fdd524f94bfad7d73fd2d478e8f2f064b24379f

I will move to PR.

santiagohermo commented 2 years ago

Continues in its PR #242

santiagohermo commented 2 years ago

Summary: In this issue we conducted production task PROOF. Final versions of annotated PDFs:

Task was reviewed jointly with #238.

Changes merged to master in https://github.com/diegogentilepassaro/min_wage_rent/commit/b86d3754a60574c6d73af6020108bef1c4a4f125

diegogentilepassaro / min_wage_rent

Production task PROOF: Proofread spelling, grammar, etc #237

Goals

Deliverables