Review MW panel and update MW maps

diegogentilepassaro / min_wage_rent

GNU General Public License v3.0

0 stars 0 forks source link

Review MW panel and update MW maps #243

Closed santiagohermo closed 2 years ago

santiagohermo commented 2 years ago

This is a follow-up to #237, and in particular https://github.com/diegogentilepassaro/min_wage_rent/pull/242#issuecomment-1190098511. We noted some unexpected things in the MW panel, which we will review in this issue.

Goals:

Check MW panel after Dec 2019. Make sure that MWs are assigned correctly
Update /descriptive/mw_US/ and /descriptive/mw_long_run/

santiagohermo commented 2 years ago

Of course it doesn't work @diegogentilepassaro:

https://github.com/diegogentilepassaro/min_wage_rent/blob/426d3fd8895350a550e3502b46df4d59b6224ee1/base/min_wage/code/substate_mw.do#L18

The date was never changed in #214. (See commit https://github.com/diegogentilepassaro/min_wage_rent/commit/1dd35cda545b3445fac640a0ce1fbb5b852a3fca.) As a result, the assignment of substate MWs was wrong after January 2020. For example:

I opened a branch and set base/min_wage/ to run. We have to re-run everything.

santiagohermo commented 2 years ago

I fixed base/min_wage in the commits above @diegogentilepassaro. I started to run the relevant steps in /derived/. I will commit them as soon as they are done.

santiagohermo commented 2 years ago

I ran the relevant parts in /derived/ and /analysis/ @diegogentilepassaro. I found that dynamic models change a bit, and static models and counterfactuals are exactly equal. This is what should happen as we changed the MW variables after January 2020 only.

Can you do the following?

Update MW plots as we discussed in #237? Please only extend the time-period of the plots to June 2020. We don't want to spend anymore time discussing changes in those plots, which we already decided on before and reviewed in #225.
Update other steps in /descriptive/ that may change due to the update in the MW panel.
Update drive/derived_large and /drive/analysis_large in the Google Drive.
Move this to PR and assign @martingallardo23. Should be a quick review I think.

diegogentilepassaro commented 2 years ago

@santiagohermo the only directory that is missing to update is descriptive/maps_mw_long_run and it is running. I have updated derived_large into the drive.

Will commit when it is ready, update analysis_large in the drive and send to PR.

santiagohermo commented 2 years ago

Sounds good. Gracias @diegogentilepassaro!

diegogentilepassaro commented 2 years ago

Just updated descriptive/maps_mw_long_run and analysis_large in the drive. Sending to PR now.

diegogentilepassaro commented 2 years ago

Continues in #244

santiagohermo commented 2 years ago

Summary: In this issue we implemented a small fix in the MW panel. See initial two comments for details.

Changes merged to master in https://github.com/diegogentilepassaro/min_wage_rent/commit/edd2f550e8530d1001afc1650335982ccae11a03