diegogentilepassaro / min_wage_rent

GNU General Public License v3.0
0 stars 0 forks source link

PR for #268 and more: revise updated manuscript #271

Closed santiagohermo closed 11 months ago

santiagohermo commented 12 months ago

Can you take a look at the paper @diegogentilepassaro @gabrieleborg? For comparison, the version as of the AER submission can be found here.

I will review the paper myself, make a few corrections, and submit on Monday. It'd be great to have your feedback, but no problem if you don't have time.

What's changed relative to previous draft

gabrieleborg commented 12 months ago

That's amazing @santiagohermo ! I will start the review now. I will finish post comments during the weekends.

santiagohermo commented 12 months ago

Thanks @gabrieleborg! Feel free to focus on the changes relative to the previous version. You may also look at the code if you have doubts.

gabrieleborg commented 11 months ago

Finished reviewing the paper. Amazing job @santiagohermo !! here's the PDF with my comments, and suggested edits. When I provide no context in the comment, you should simply take that as a suggested edit. Feel free to accept it or not :)

As for the extended "Summary and Discussion" session, I like it and I think it's clear. I didn't have comments on that.

min_wage_rent (1).pdf

santiagohermo commented 11 months ago

Thanks @gabrieleborg! I finished my review myself, I'll proceed to implement changes and get ready for a new submission

santiagohermo commented 11 months ago

Here are some replies to your comments @gabrieleborg: min_wage_rent.gb.sh.pdf

I implemented many (see https://github.com/diegogentilepassaro/min_wage_rent/pull/271/commits/23a70a7bb1d7d901f274bb427f06b9de62eb1d41). Of the ones I didn't implement, I provided explanations for some. I mostly ignored a few that were about things that did not change relative to our previous draft (so were already reviewed extensively)

santiagohermo commented 11 months ago

Summary here