Switch http client to gopkg.in/h2non/gentleman.v1

diegogub / aranGO

Golang driver for ArangoDB

Apache License 2.0

125 stars 31 forks source link

Switch http client to gopkg.in/h2non/gentleman.v1 #31

Open hnakamur opened 8 years ago

hnakamur commented 8 years ago

After the discussion at https://github.com/diegogub/aranGO/issues/28#issuecomment-231632559, I'm trying to implement sending http requests with gopkg.in/h2non/gentleman.v1.

Currently I successfully get the version in Connect and log requests and responses. https://github.com/diegogub/aranGO/compare/v2...hnakamur:96ec36d14ec6dfb1be21c6f74607fb84f9147ff2

Could you tell me what do you think? If it's ok, I'll continue to switch all occurrences of sending requests to gopkg.in/h2non/gentleman.v1.

hnakamur commented 8 years ago

I'm inclined to write wrapper for gentleman to have the same methods as github.com/diegogub/napping. I think it's easier than replacing all occurrences of sending requests.