search

diegohaz / arc

React starter kit based on Atomic Design
https://arc.js.org
2.92k stars 292 forks source link

Move src to src-example #213

Closed diegohaz closed 7 years ago

diegohaz commented 7 years ago

The diff is weird, but the relevant changes were made on webpack.config.js and package.json

I'm really happy about this PR.

Basically, we are moving src to src-example and making src-clean the new src, which removes a setup step (mv src src-example && mv src-clean src).

It could also help with #194 since src will receive less changes and therefore cause less conflicts on those projects that forked ARc and kept commit history (what do you think, @kybarg?).

This fits well on master, redux and also the oncoming redux-ssr (since that will also build the server code). I'm not sure what to do with universal-redux and fullstack though, because they run code directly from the source folder.

codecov-io commented 7 years ago

Codecov Report

Merging #213 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #213   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          40     42    +2     
  Lines         275    280    +5     
  Branches       54     54           
=====================================
+ Hits          275    280    +5
Impacted Files Coverage Δ
src-example/components/pages/NotFoundPage/index.js 100% <ø> (ø)
src-example/components/organisms/Organism/index.js 100% <ø> (ø)
src-example/components/atoms/Link/index.js 100% <ø> (ø)
...mple/components/templates/GenericTemplate/index.js 100% <ø> (ø)
src-example/components/molecules/Field/index.js 100% <ø> (ø)
src-example/components/molecules/Modal/index.js 100% <ø> (ø)
...-example/components/organisms/FeatureList/index.js 100% <ø> (ø)
src/components/pages/HomePage/index.js 100% <ø> (ø) :arrow_up:
src-example/components/atoms/Button/index.js 100% <ø> (ø)
src-example/components/atoms/Tooltip/index.js 100% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update caa3d45...5528396. Read the comment docs.

kybarg commented 7 years ago

@diegohaz This is awesome PR! I see how it will make maintaining my projects easier) I hope in future ARC can become separate package, smth similar to Next.js but better 😂