search

diegohaz / arc

React starter kit based on Atomic Design
https://arc.js.org
2.92k stars 292 forks source link

Upgrade react to 15.5.x #214

Closed kybarg closed 7 years ago

kybarg commented 7 years ago

Some related packages aren't upgraded yet

  1. https://github.com/styled-components/styled-components/pull/683
  2. https://github.com/commissure/redbox-react/pull/88
  3. https://github.com/reactjs/react-modal/pull/374
  4. https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types/pull/88
codecov-io commented 7 years ago

Codecov Report

Merging #214 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #214   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          40     40           
  Lines         275    275           
  Branches       54     54           
=====================================
  Hits          275    275
Impacted Files Coverage Δ
src/components/molecules/Modal/index.js 100% <ø> (ø) :arrow_up:
src/components/atoms/Input/index.js 100% <ø> (ø) :arrow_up:
src/components/atoms/Label/index.js 100% <ø> (ø) :arrow_up:
src/components/atoms/Atom/index.js 100% <ø> (ø) :arrow_up:
src/components/atoms/List/index.js 100% <ø> (ø) :arrow_up:
test/componentsMock.js 100% <ø> (ø) :arrow_up:
src/components/molecules/Feature/index.js 100% <ø> (ø) :arrow_up:
src/components/atoms/HorizontalRule/index.js 100% <ø> (ø) :arrow_up:
src/components/atoms/Button/index.js 100% <ø> (ø) :arrow_up:
src/components/atoms/Icon/index.js 100% <ø> (ø) :arrow_up:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update caa3d45...a2736f5. Read the comment docs.

diegohaz commented 7 years ago

Awesome. Is there a way to not include prop-types package in production? Since we use babel-plugin-transform-react-remove-prop-types (https://github.com/diegohaz/arc/blob/master/.babelrc#L25)

kybarg commented 7 years ago

@diegohaz you're right, I will investigate it now.

kybarg commented 7 years ago

@diegohaz it looks like PR was made to https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types but not released yet.

diegohaz commented 7 years ago

213 produced a bunch of conflicts on this. But they are automatically solved with git merge. I did that, but this PR doesn't allow edit from authors :(

There's another warning from react-modal related to this: https://github.com/reactjs/react-modal/issues/367 I approved the PR on styled-components repo, but didn't see if that's enough to get rid of the warning since styled-components library itself contains some React.PropTypes references.

Besides that, it looks very good to me.

kybarg commented 7 years ago

@diegohaz nice 👍