diegohaz / arc

React starter kit based on Atomic Design
https://arc.js.org
2.92k stars 292 forks source link

[redux] Remove react-router-redux #230

Closed diegohaz closed 7 years ago

diegohaz commented 7 years ago

react-router-redux is still in alpha and still has a lot of things to implement. SSR integration is inconsistent and time travel through redux-devtools still doesn't work.

We can just pass the history object to actions and receive it on sagas to do the same thing.

codecov-io commented 7 years ago

Codecov Report

Merging #230 into redux will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           redux   #230   +/-   ##
====================================
  Coverage    100%   100%           
====================================
  Files         74     74           
  Lines        771    771           
  Branches     184    184           
====================================
  Hits         771    771

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f90b2cd...e4d2411. Read the comment docs.

Geczy commented 7 years ago

whaaat

diegohaz commented 7 years ago

I'll put it back when it's officially released.

For now, we can just follow what's stated on react-router docs (https://reacttraining.com/react-router/core/guides/redux-integration/deep-integration):

  • Route changes are unlikely to matter for time travel debugging.
  • Rather than dispatching actions to navigate you can pass the history object provided to route components to your actions and navigate with it there.
  • Routing data is already a prop of most of your components that care about it, whether it comes from the store or the router doesn’t change your component’s code.