search

diegohaz / arc

React starter kit based on Atomic Design
https://arc.js.org
2.92k stars 292 forks source link

[Redux] #264 API settings parser merges additional settings #265

Closed dennis-tra closed 7 years ago

dennis-tra commented 7 years ago

If header fields are passed into parseSettings they'll overwrite the default headers completely. This pull request fixes issue #264. It merges new settings/headers to the default ones.

codecov-io commented 7 years ago

Codecov Report

Merging #265 into redux will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           redux   #265   +/-   ##
====================================
  Coverage    100%   100%           
====================================
  Files         76     75    -1     
  Lines        760    733   -27     
  Branches     174    155   -19     
====================================
- Hits         760    733   -27
Impacted Files Coverage Δ
src-example/services/api/index.js 100% <100%> (ø) :arrow_up:
src-example/services/validation/index.js

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08e433c...39fc606. Read the comment docs.

diegohaz commented 7 years ago

Nice! Thank you, @dennis-tra.