search

diegohaz / arc

React starter kit based on Atomic Design
https://arc.js.org
2.91k stars 295 forks source link

[redux] Use `fork` instead of `call` #306

Closed mrotaru closed 7 years ago

mrotaru commented 7 years ago

Attempt at https://github.com/diegohaz/arc/issues/303

codecov-io commented 7 years ago

Codecov Report

Merging #306 into redux will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            redux     #306      +/-   ##
==========================================
- Coverage   99.71%   99.71%   -0.01%     
==========================================
  Files          71       71              
  Lines         695      690       -5     
  Branches      164      152      -12     
==========================================
- Hits          693      688       -5     
  Misses          2        2
Impacted Files Coverage Δ
src-example/store/resource/sagas.js 100% <100%> (ø) :arrow_up:
src-example/services/validation/index.js
src-example/services/api/index.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44a81d9...afb6f09. Read the comment docs.

diegohaz commented 7 years ago

Thank you very much, @mrotaru.

But I think we should make as few changes as possible. Wouldn't simply changing resource's calls to forks fix the issue?

If so, could you please do that?

mrotaru commented 7 years ago

@diegohaz done & updated to use @orther's approach - seems more idiomatic and makes things a bit simpler as well.

diegohaz commented 7 years ago

Awesome, @mrotaru. Thank you