[QUESTION] passing all configs as ENV VAR in CI

diegohaz / arc

React starter kit based on Atomic Design

https://arc.js.org

2.92k stars 292 forks source link

[QUESTION] passing all configs as ENV VAR in CI #311

Closed zhenyulin closed 7 years ago

zhenyulin commented 7 years ago

arc/src/config.js

It looks in this repo a large portion of configs can be setup via process.env, while it seems in webpack process.env is only passed in via the DefinePlugin. Is there something I missed here?

diegohaz commented 7 years ago

Hi, @zhenyulin

You just need to set them before running npm run build.