search

diegohaz / arc

React starter kit based on Atomic Design
https://arc.js.org
2.91k stars 295 forks source link

Upgrade to React 16? #320

Closed mininternet closed 6 years ago

mininternet commented 6 years ago

Are there any plans to upgrade to React 16 now that it's in production?

https://facebook.github.io/react/blog/

diegohaz commented 6 years ago

Sure, would you like to send a PR?

mininternet commented 6 years ago

I would like to, but i'm in the middle of launching my current project with a very old version of Arc.

Will be moving on to my next project with the newest version of Arc, so perhaps i will have time then.

diegohaz commented 6 years ago

Ok then, I'm gonna keep this open since it will be a very easy first PR for anyone.

Geczy commented 6 years ago

Not if 80% of the packages don't support R16 yet :D

mininternet commented 6 years ago

The React team put a lot of work into making 16 backwards compatible, up to 15.6 according to them.

(I'd be surprised though if there were actually 0 breaking changes.)

Does seem like a major upgrade though - Fiber, smaller file size, no need for wrapping containers, componentDidCatch, etc., but yes, would require a significant amount of testing, which was my main concern.

mininternet commented 6 years ago

Quick update - i upgraded the latest version of ARc to React 16, and had zero breaking changes.

However, my version of ARc differs in that i swapped Styled Components for SASS, and also removed React Modal.

Just an fyi.