search

diegohaz / arc

React starter kit based on Atomic Design
https://arc.js.org
2.91k stars 296 forks source link

[master] Update dependencies and adjust code to the new API #355

Closed kybarg closed 5 years ago

kybarg commented 5 years ago

Highlights

  1. Updated webpack to version 4
  2. Removed webpack-blocks dependency in favor of plain config file
  3. Updated babel
  4. Dropped support for Node.js 6
  5. Removed unused dependencies

Fixes #347, #349

@diegohaz I think using webpack-blocks adds more dependencies and complexity to the part that barely changes during version life cycle, that's why I deleted it, moreover it is not supported enough lately. if you approve, will work on providing PRs for redux and redux-ssr branches.

codecov-io commented 5 years ago

Codecov Report

Merging #355 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #355   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          43     43           
  Lines         295    297    +2     
  Branches       57     57           
=====================================
+ Hits          295    297    +2
Impacted Files Coverage Δ
src-example/components/pages/NotFoundPage/index.js 100% <ø> (ø) :arrow_up:
...-example/components/organisms/FeatureList/index.js 100% <ø> (ø) :arrow_up:
src-example/components/organisms/Hero/index.js 100% <ø> (ø) :arrow_up:
src-example/components/pages/SamplePage/index.js 100% <ø> (ø) :arrow_up:
src-example/components/pages/HomePage/index.js 100% <ø> (ø) :arrow_up:
src-example/components/organisms/Footer/index.js 100% <ø> (ø) :arrow_up:
...c-example/components/molecules/IconButton/index.js 100% <100%> (ø) :arrow_up:
src-example/components/molecules/Slider/index.js 100% <100%> (ø) :arrow_up:
src-example/components/atoms/Input/index.js 100% <100%> (ø) :arrow_up:
src-example/components/molecules/IconLink/index.js 100% <100%> (ø) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e52205c...e759f04. Read the comment docs.

diegohaz commented 5 years ago

Thank you so much @kybarg

Only one thing: are all those babel plugins necessary?

kybarg commented 5 years ago

@diegohaz babel since version 7 has broken everything into separate plugins... I guess to be able to drop them easyly when all features are implemented natively

EricWVGG commented 5 years ago

Thank you @kybarg, looking forward to the redux-ssr branch.

Sashkan commented 5 years ago

@kybarg Any updates on the portage to redux-ssr ?