Closed BrenoMazieiro closed 4 years ago
Merging #356 into redux will decrease coverage by
0.5%
. The diff coverage is100%
.
@@ Coverage Diff @@
## redux #356 +/- ##
==========================================
- Coverage 99.72% 99.22% -0.51%
==========================================
Files 73 72 -1
Lines 735 773 +38
Branches 178 175 -3
==========================================
+ Hits 733 767 +34
- Misses 2 6 +4
Impacted Files | Coverage Δ | |
---|---|---|
...-example/components/organisms/FeatureList/index.js | 100% <ø> (ø) |
:arrow_up: |
src-example/components/organisms/Hero/index.js | 100% <ø> (ø) |
:arrow_up: |
src-example/components/pages/HomePage/index.js | 100% <ø> (ø) |
:arrow_up: |
src-example/store/gtm/sagas.js | 100% <ø> (ø) |
:arrow_up: |
src-example/store/resource/reducer.js | 94.44% <ø> (ø) |
:arrow_up: |
src-example/components/pages/NotFoundPage/index.js | 100% <ø> (ø) |
:arrow_up: |
src-example/components/organisms/Footer/index.js | 100% <ø> (ø) |
:arrow_up: |
...c-example/components/molecules/IconButton/index.js | 100% <100%> (ø) |
:arrow_up: |
src-example/components/atoms/Block/index.js | 100% <100%> (ø) |
:arrow_up: |
...c-example/components/organisms/LoginModal/index.js | 100% <100%> (ø) |
:arrow_up: |
... and 36 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 94132ca...15a11c2. Read the comment docs.
Well, that is it! Every package is updated! Coverage at 99%
BUT
Things I was not able to do:
1-) When running the test I've got warnings like: It looks like you've wrapped styled() around your React component (Icon), but the classNa me prop is not being passed down to a child. No styles will be rendered unless className is com posed within your React component.
2-) At console Browser there is a warning: React-Hot-Loader: react-🔥-dom patch is not detected. React 16.6+ features may not work.
3-) When update storybook/react and storybook/addon-actions to 5.0.5: Ive got a error running "yarn storybook:example" Something about the webpack.config file inside private folder.
anyone willing to help me? Thanks guys!
Well, that is it! Every package is updated! Coverage at 99%
BUT
Things I was not able to do:
1-) When running the test I've got warnings like: It looks like you've wrapped styled() around your React component (Icon), but the classNa me prop is not being passed down to a child. No styles will be rendered unless className is com posed within your React component.
2-) At console Browser there is a warning: React-Hot-Loader: react-🔥-dom patch is not detected. React 16.6+ features may not work.
3-) When update storybook/react and storybook/addon-actions to 5.0.5: Ive got a error running "yarn storybook:example" Something about the webpack.config file inside private folder.
anyone willing to help me? Thanks guys!
I'm also having problems with the storybook thing, but what u did would really be helpful, someone should review and release this PR.
@BrenoMazieiro Thank you for you contribution, going to check this PR over the weekend.
Hey @BrenoMazieiro, I was able to fix the webpack configuration for the storybook update, don't know if I should wait for this PR to be released to open my PR or if I should do it now, what are u thoughts on it ?
I believe it depends, if you made it from my PR, you should wait, because maybe soon enough we will have an answer on mine. If you made from redux branch, then open a PR. Anyway I'm curious to know how it solved the problem!
Maybe @diegohaz or @kybarg can help us with it!
@gfsd3v if your PR is based on @BrenoMazieiro's branch, you can open a new PR with his commits included.
@gfsd3v and @diegohaz, updated, all errors and warnings is now ok, and storybook it is in its last version.
@diegohaz everything looks perfect so far @BrenoMazieiro thanks for effort, I think gonna merge this in couple days
Thank you for the awesome work, @BrenoMazieiro (sent you an invitation to be collaborator on this project)! And thank you @kybarg for reviewing this! ❤️
Is anyone actively working on the Redux-SSR branch?
@EricWVGG Not that I’m aware of
Like @kybarg
Highlights
Plus