search

diegohaz / generact

Generate React components by replicating your own
https://git.io/generact
MIT License
1.48k stars 64 forks source link

Add fixtures, and test for Link component with package json #8

Closed dmitrika closed 7 years ago

dmitrika commented 7 years ago

Closes #4 It works, but if we do not specify second attribute componentName for getFiles function, is that ok?

dmitrika commented 7 years ago

Huh, locally I have all test passed. Seems, like travis has different setup.

I added fixtures by git clone repo in the fixtures dir, is that correct way?

diegohaz commented 7 years ago

@dmitrika I think you need to rm -rf .git inside test/fixtures/react-static-boilerplate. Otherwise it will be read as a git submodule.

codecov-io commented 7 years ago

Codecov Report

Merging #8 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          31     31           
  Branches        4      4           
=====================================
  Hits           31     31
Impacted Files Coverage Δ
src/utils.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56beefa...f5f1957. Read the comment docs.

dmitrika commented 7 years ago

Yeap, looks like it helped!

I didn't know it before, btw 🤓

diegohaz commented 7 years ago

Nice. Thank you, @dmitrika 😊

dmitrika commented 7 years ago

Thank you for excellent support!