diegoles / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

net.xpc.CrossPageChannel.createPeerIframe should use this.domHelper_.createElement instead of goog.dom.createElement #442

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Create a page (Page A) that loads a same-domain iframe (Page B)
2. Inside of Page B, create a goog.net.xpc.CrossPageChannel instance passing in 
a DomHelper for page A.
eg. var xpc = new goog.net.xpc.CrossPageChannel({}, new 
goog.dom.DomHelper(window.parent.document));
3. Call createPeerIframe passing in a DOM element from Page A as parentElm.

What is the expected output? What do you see instead?
Chrome and Firefox allow you to append an element created within a different 
iframe
IE6+ with throw and 'Invalid argument' when trying to insert the iframe element 
in the parentElm
Specifically the following line:
parentElm.appendChild(iframeElm);

What version of the product are you using? On what operating system?
Internet Explorer 7, Windows Vista

Please provide any additional information below.
The following change fixes the error in Internet Explorer:
change: var iframeElm = goog.dom.createElement('IFRAME');
to: var iframeElm = this.domHelper_.createElement('IFRAME'); 

Original issue reported on code.google.com by parker.s...@gmail.com on 28 Mar 2012 at 4:15

GoogleCodeExporter commented 8 years ago
thanks for the report!

Original comment by Nicholas.J.Santos on 28 Mar 2012 at 7:55

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r1695.

Original comment by Nicholas.J.Santos on 29 Mar 2012 at 7:02

GoogleCodeExporter commented 8 years ago
thanks for the fast turn around.

Original comment by parker.s...@gmail.com on 3 Apr 2012 at 4:11