diegoles / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

new goog.Uri('file:///a/b').toString() returns 'file:/a/b' #492

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1.
    goog.require('goog.Uri');
    goog.require('goog.asserts');

    var file = 'file:///a/b/c/d';
    var fileUri = new goog.Uri(file).toString();
    goog.asserts.assert(fileUri === file);

What is the expected output? What do you see instead?
Expect the assert above to pass.  

Instead, fileUri equals "file:/a/b/c/d".

What version of the product are you using? On what operating system?
Closure library r2029

Please provide any additional information below.
When you type "file:///a/b/c/d" into chrome, it remains "file:///a/b/c/d".
When you type "file:/a/b/c/d" into chrome, it redirects to "file:///a/b/c/d".

Note: we cannot accept patches without the contributor license agreement
being signed. See http://code.google.com/p/closure-
library/wiki/Contributors for more info.

Original issue reported on code.google.com by Bitwise...@gmail.com on 28 Aug 2012 at 9:02

GoogleCodeExporter commented 8 years ago
Here is a proposed fix: http://codereview.appspot.com/6500044/

Original comment by Bitwise...@gmail.com on 29 Aug 2012 at 3:54

GoogleCodeExporter commented 8 years ago
I've submitted a signed contributor agreement.

Original comment by Bitwise...@gmail.com on 31 Aug 2012 at 5:18

GoogleCodeExporter commented 8 years ago
It doesn't look like this was ever included.

Perhaps you could make a pull request for 
https://github.com/google/closure-library.

Original comment by p...@lucidchart.com on 4 Jul 2014 at 10:51

GoogleCodeExporter commented 8 years ago
I have a pending fix for this. Watch 
https://github.com/google/closure-library/issues/104 for updates.

Original comment by joelt...@google.com on 20 Aug 2015 at 10:24