diegoles / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

EventHandler should be disposed in goog.fx.Dragger #532

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
Create and dispose goog.editor with monitoring instances as below.

goog.Disposable.MONITORING_MODE = goog.Disposable.MonitoringMode.PERMANENT;
var el = goog.dom.createDom('div');
document.body.appendChild(el);

var dragger = new goog.fx.Dragger(el);
dragger.dispose();

var undisposedObjects = goog.Disposable.getUndisposedObjects();
console.log(undisposedObjects.length);

What is the expected output? What do you see instead?
The console output
expected: 0
actual: 1

What version of the product are you using? On what operating system?
r2325

Please provide any additional information below.
The event handler is not disposed.
(https://code.google.com/p/closure-library/source/browse/trunk/closure/goog/fx/d
ragger.js?r=2325#63)

Original issue reported on code.google.com by miyajan...@gmail.com on 24 Jan 2013 at 11:37

GoogleCodeExporter commented 8 years ago
> Create and dispose goog.editor with monitoring instances as below.

Sorry, not goog.editor but goog.fx.Dragger.

Original comment by miyajan...@gmail.com on 24 Jan 2013 at 11:42

GoogleCodeExporter commented 8 years ago

Original comment by pall...@google.com on 12 Mar 2013 at 1:42

GoogleCodeExporter commented 8 years ago

Original comment by pall...@google.com on 12 Mar 2013 at 1:46

GoogleCodeExporter commented 8 years ago
This issue was closed by revision b83c732bfba9.

Original comment by nn...@google.com on 14 Mar 2013 at 3:50

GoogleCodeExporter commented 8 years ago
This issue was closed by revision 1eadfb6df887.

Original comment by nn...@google.com on 14 Mar 2013 at 3:50

GoogleCodeExporter commented 8 years ago
Thanks for very fast fix!

Original comment by miyajan...@gmail.com on 15 Mar 2013 at 2:33