search

diegoles / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

goog.ui.media.FlashObject breaks in IE11 #630

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Create and render an instance of goog.ui.media.FlashObject
2. Test on IE 11

What is the expected output? What do you see instead?
Flash movie should be rendered, but nothing happens.

IE 11 appears to have switched to the Gecko/Webkit style of using an embed tag 
for flash content rather than the object tag used by previous versions of IE.  
I was able to work around the issue by adding the following check to my code 
before the first call to .render():
  if (goog.userAgent.isDocumentModeOrHigher(11)) {
    goog.ui.media.FlashObject.IE_HTML_ = goog.ui.media.FlashObject.FF_HTML_;
    goog.ui.media.FlashObject.IE_WMODE_PARAMS_ = goog.ui.media.FlashObject.FF_WMODE_PARAMS_;
  }

Presumably this check should be incorporated in lines 559 and 562 of 
/closure/goog/ui/media/flashobject.js

Original issue reported on code.google.com by andrew.c...@period7.com on 17 Mar 2014 at 10:41

GoogleCodeExporter commented 8 years ago 
This was fixed in 
https://github.com/google/closure-library/commit/3f950c0ce18b95bfee9e35a37d40365
dab124817

Original comment by joelt...@google.com on 17 Jul 2015 at 10:07