diegoles / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

bad inheritance: goog.iter.GroupByIterator < goog.iter.Iterator #638

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Try to compile closure/goog/iter/iter.js with --jscomp_error=checkTypes

What is the expected output? What do you see instead?

Nothing, but I get 

/closure/goog/iter/iter.js:944: ERROR - mismatch in declaration of superclass 
type
found   : goog.iter.Iterator
required: goog.iter.Iterator.<Array>
goog.inherits(goog.iter.GroupByIterator_, goog.iter.Iterator);
^

1 error(s), 0 warning(s)

What version of the product are you using? On what operating system?

HEAD

Please provide any additional information below.

Note: we cannot accept patches without the contributor license agreement
being signed. See http://code.google.com/p/closure-
library/wiki/Contributors for more info.

Original issue reported on code.google.com by lgand...@gmail.com on 10 Apr 2014 at 4:14

GoogleCodeExporter commented 8 years ago
It seems that it hasn't ever been modified since introduction (Sep 30, 2013): 
c0a3561dd093b616ac569f445f4a49b0ad94edc3 is this on purpose?

Original comment by lgand...@gmail.com on 10 Apr 2014 at 4:37

GoogleCodeExporter commented 8 years ago
Found that

@@ -903,7 +903,7 @@ goog.iter.compress = function(iterable, selectors) {
  *     determining the key value for each group in the {@code iterable}. Default
  *     is the identity function.
  * @constructor
- * @extends {goog.iter.Iterator.<!Array>}
+ * @extends {goog.iter.Iterator}
  * @template KEY, VALUE
  * @private
  */

mitigates the issue. Is this ok?

Original comment by lgand...@gmail.com on 10 Apr 2014 at 4:44

GoogleCodeExporter commented 8 years ago
This file has been updated quite a few times since this was opened. See 
https://github.com/google/closure-library/issues/2. 

Original comment by joelt...@google.com on 20 Jul 2015 at 10:13