search

diegomura / jay-peg

Performant JPEG decoder
MIT License
7 stars 2 forks source link

Version 1.0.2 on npm is the same as 1.0.1 #7

Open terence1990 opened 4 months ago

terence1990 commented 4 months ago

Looks like npm run build (or whatever you're using to compile) may not have been ran before npm publish for 1.0.2..

For example, the dist/index.cjs still shows on line 347

entries.gpsInfo = IFDHandler(subuffer, $0b53e5b7c7fe341c$var$tags.gps, gps);

rather than

entries.gpsInfo = this._decodeIDFEntries(buffer, $0b53e5b7c7fe341c$var$tags.gps, gps);

but line 271 is the src/marjers/exif.js in the bundle is as expected:

entries.gpsInfo = this._decodeIDFEntries(buffer, tags.gps, gps, true);

Result being i need to run npm i && npm run build in the node_modules/jay-peg after npm i to ensure the issue related to this change is resolved

gabrielhamel commented 4 months ago

@diegomura It seem there was a confusion when you've uploaded the package

trueter commented 2 weeks ago

Bumping for visibility. The IFDHandler is not defined is still creating issues in projects working with react-pdf.