diegomura / react-pdf

📄 Create PDF files using React
https://react-pdf.org
MIT License
15.04k stars 1.19k forks source link

Use main pdfkit repo #2613

Open diegomura opened 10 months ago

diegomura commented 10 months ago

I'd like to remove pdfkit fork and start using https://github.com/foliojs/pdfkit again. I branched from this a long time ago for multiple reasons, so I'm not sure the lift here. It will mean for sure to add several changes in that repo, which I think it could benefit the entire community, but not sure yet what those are.

I'll keep this issue as a sort of umbrella issue where I'll capture all the differences and report progress as I tackle them. It will be a slow path.

wojtekmaj commented 10 months ago

Hey, regarding png-js bit - consider pngjs too! See my comment: https://github.com/diegomura/react-pdf/issues/676#issuecomment-1930922597

diegomura commented 10 months ago

Thanks! Just took a quick look, and pngjs has node deps too, meaning I'll need to fork it as for now, or have them onboard on shipping a browser build. And also convince pdfkit to adopt this. Because pdfkit already uses png-js the path towards unifying this is shorter, but I'll check what would be more convenient

kishaningithub commented 5 months ago

@foliojs Can you kindly pitch in and add your thoughts here?