search

diegomura / react-pdf

📄 Create PDF files using React
https://react-pdf.org
MIT License
14.22k stars 1.11k forks source link

Add back functionality for bookmark props #2715

Open mgmolisani opened 1 month ago

mgmolisani commented 1 month ago

This restores functionality that seemed to have accidentally erased in a minor version update to converge the forked pdfkit vendor package. This resulted in all bookmarks being created in fit mode on the last page not respecting any of the props.

I additionally added some comments to roughly show where the custom logic of this file exists to give some signal that this should not be altered in future fork maintenance.

I tested this locally in a simple repro and observed both the raw output and the PDF in Adobe Reader were again properly linking to the page and respecting props.

There are no unit tests for the custom logic in this vendor package hence I did not add any new ones.

Resolves https://github.com/diegomura/react-pdf/issues/2700

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 804871667610e880ee68b83d11e1b6783def6e04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

typesafeui commented 4 weeks ago

Nice! this probably closes #2682 too 🙌