diegonetto / generator-ionic

Build hybrid mobile apps using the Ionic Framework
MIT License
1.74k stars 336 forks source link

Convert ionic seed app to generator-angular standards #19

Open douglascorrea opened 10 years ago

douglascorrea commented 10 years ago

When use:

yo angular:[command]

it creates controllers, services, views and so on, in generator-angular default folders that is different from Ionic seed standard.

Maybe if generator-ionic uses an seed app with generator-angular defaults could be better to continue using yo angular:[commands]

diegonetto commented 10 years ago

I was considering pulling in generator-angular as a sub-generator, but hadn't made a decision yet. I'm leaning more towards it being a good idea, in which case the seed app will indeed have to be restructured.

Will see if I can knock this out tonight.

mhartington commented 10 years ago

Hey any progress on this?

diegonetto commented 10 years ago

None so far since I ended up focusing my efforts on other areas of the generator. However, of all the open enhancement requests, this is priority number one on my list.

robkorv commented 10 years ago

Today I decided to just give generator-angular inside the Ionic dir a go.

I can use the generators. Avoid angular:app (will generate a complete angular app) and angular:route (will generate, controller, view and route while Ionic uses AngularUI for routing).

I can confirm that angular:controller and angular:view works while using grunt serve. Apart from some different dir usage, it's pretty functional.

deedubbleyoo commented 10 years ago

Good to know that a lot of the standard generators work: my team was asking for this today - it would be great if you full integrated yo angular (or a version that handles ui-router etc.) into the generator.

Kudos on this project - we have become super-productive and have been able to re-scaffold an app in days compared to months for the previous application.

JaKXz commented 10 years ago

Any progress on getting a ui-router generator working?

This generator looks promising! :smile:

diegonetto commented 10 years ago

Looking to start pulling in generator-angular towards the end of this week.

diegonetto commented 10 years ago

Was about to post a design discussion topic about directory structure, since for all of my contract projects I've been using a component-centric directory structure instead of generator-angular's controllers/, directives/, services/, etc structure. I've found that a component-driven architecture makes working on large projects much more manageable.

This proposal was brought to my attention today by @jcumminsr1, so I'm holding off on pulling in the Angular Generator until we see how it shakes out.

Ultimately, I'd like to support generator-angular's adoption of the fractal hierarchy described in that proposal, since its almost identical to what I, and many others, have been using for large industry projects.

alexkb commented 9 years ago

We're trialing Ionic and Angular and wanted to use yo angular:<type> <name> to create controllers, directives and services. It seems to work fine with a project created with generator-ionic, except for the way generator-angular detects the angular module name. It detects the module name, but converts it to lowercase and appends "App" to the end. Manually editing this resolves the problem for the time being but it would be good for this to work out of the box.

As for the discussion on fractal hierarchy, we aren't at the stage yet where the application is so large it needs all this separation.

LunarDevelopment commented 9 years ago

Any further progress with this?

+1