$scope.$apply() not called on "created" message

diegopamio / angular-sails-bind

An angular service to bind scope models to sailsjs models thru socket

MIT License

136 stars 25 forks source link

$scope.$apply() not called on "created" message #15

Closed talss89 closed 10 years ago

talss89 commented 10 years ago

We've just noticed $apply() isn't called when receiving a model created message from Sails. I've only just started using the module, so haven't tested any other events. We're using autoWatch:true.

Angular 1.0.8 Sails 0.10.0

I've fixed this on my local machine. Let me know if you want a pull request.

talss89 commented 10 years ago

This is for all messages in Angular 1.0.8

artur-krueger commented 10 years ago

You're right, it was really missing. My pull request that was merged yesterday already fixes it.

talss89 commented 10 years ago

Ahh great - thanks! Looks good to me.

diegopamio commented 10 years ago

Can I close it then as the merge would solver the issue?

talss89 commented 10 years ago

Yep, master works for me. It would be nice to have the changes in /dist/ and maybe a tagged release for bower?

MEugeC commented 10 years ago

Please do it ASAP

diegopamio commented 10 years ago

There you have it, tagged, published in /dist and updated for the published version in bower (1.0.4).