search

diegopamio / angular-sails-bind

An angular service to bind scope models to sailsjs models thru socket
MIT License
136 stars 25 forks source link

firefox errors #4

Closed z0d14c closed 10 years ago

z0d14c commented 10 years ago

Getting various errors in Firefox using the firebug console:

Error: model.forEach is not a function 

addCollectionWatchersToSubitemsOf@https://10.0.2.204/js/bower_components/angular-

sails-bind/dist/angular-sails-bind.js:120:7 bind/<@https://10.0.2.204

/js/bower_components/angular-sails-bind/dist/angular-sails-bind.js:45:9 

Re/e/l.promise.then/J@https://10.0.2.204/js/angular.min.js:101:1

Along with others. Not really sure what could be causing it as I am mostly a newb but just thought I would throw it on here in case anyone else was having the same problem or had some input. Working fine in Chrome. If theres any useful info you want from me I can try to provide it, but we aren't doing anything particularly special.

diegopamio commented 10 years ago

Ouch, that's quite bad! Let me see if I can figure out what's happening. Which version of FF are you using? It is weird as my tests run on FF (Linux OS, version 27, though).

Thanks for reporting it!

z0d14c commented 10 years ago

Fixed, changed model.forEach to angular.forEach. Had to do similar things for several other functions. using firefox 30

diegopamio commented 10 years ago

Awesome, could you please make a pull request for this change so it becomes part of the master?

diegopamio commented 10 years ago

Should be fixed with #8 .

z0d14c commented 10 years ago

Thanks!