search

diegoveloper / flutter_percent_indicator

Flutter percent indicator library
BSD 2-Clause "Simplified" License
691 stars 206 forks source link

percent < 0 #1

Closed bradintheusa closed 6 years ago

bradintheusa commented 6 years ago

setting percent < 0.0 is a bad idea but I think the control should display an empty progress bar not an error.

diegoveloper commented 6 years ago

It depends on how you see it, if it's an incorrect value it is best to display an error, otherwise the developer won't know why it does not display anything. But I will leave this issue open to see if others require it. Thanks

bradintheusa commented 6 years ago

BTW: It's in production now. The screenshots in the store have not been updated but the app is using the component. Thanks For You work..

https://play.google.com/store/apps/details?id=com.scrbrd.playcounter2

diegoveloper commented 6 years ago

Awesome !!!