diegoveloper / flutter_percent_indicator

Flutter percent indicator library
BSD 2-Clause "Simplified" License
679 stars 206 forks source link

[#33] Diameter & Radius Confusion #140

Closed nvshah closed 2 years ago

nvshah commented 2 years ago

Fix #33 :- facilitate true radius for CircularPercentIndicator

diegoveloper commented 2 years ago

Can you run the samples inside this package and add some screenshots to see how those looks like ?

nvshah commented 2 years ago

@diegoveloper

Please find the snaps as attached below :

1)

2)

NOTE :- In second Image, as radius goes beyond the 400, so it shows overflow !

3)

diegoveloper commented 2 years ago

@diegoveloper

Please find the snaps as attached below :

Circular_Snap1

Circular_Snap2

NOTE :- In second Image, as radius goes beyond the 400, so it shows overflow !

Circular_Snap3

Yes, as you can see it's breaking the current behavior, it will happen the same with all of the current users/devs that are using this package.

This is a breaking change, can you also update the current samples? and use the half of the current "radius" (the sample should looks the same as before this change ).

nvshah commented 2 years ago

@diegoveloper Yes when radius is taken half, then it resembles same as earlier Should I attach snaps for same ??

diegoveloper commented 2 years ago

yes please :)

nipun-solutelabs commented 2 years ago

@diegoveloper

Please find images with radius = half of what above taken

diegoveloper commented 2 years ago

ok, it looks good, don't forget to push your changes.

nvshah commented 2 years ago

Done (pushed sample dart file changes for half-radius as well)