Closed nvshah closed 2 years ago
Can you run the samples inside this package and add some screenshots to see how those looks like ?
@diegoveloper
Please find the snaps as attached below :
1)
2)
NOTE :- In second Image, as radius goes beyond the 400, so it shows overflow !
3)
@diegoveloper
Please find the snaps as attached below :
NOTE :- In second Image, as radius goes beyond the 400, so it shows overflow !
Yes, as you can see it's breaking the current behavior, it will happen the same with all of the current users/devs that are using this package.
This is a breaking change, can you also update the current samples? and use the half of the current "radius" (the sample should looks the same as before this change ).
@diegoveloper Yes when radius is taken half, then it resembles same as earlier Should I attach snaps for same ??
yes please :)
@diegoveloper
Please find images with radius = half of what above taken
ok, it looks good, don't forget to push your changes.
Done (pushed sample dart file changes for half-radius as well)
Fix #33 :- facilitate true radius for CircularPercentIndicator