diegoveloper / flutter_percent_indicator

Flutter percent indicator library
BSD 2-Clause "Simplified" License
677 stars 206 forks source link

Merge example logic in one single file #152 #178

Open ivofernandes opened 1 year ago

ivofernandes commented 1 year ago

As we talked on this issue

https://github.com/diegoveloper/flutter_percent_indicator/issues/152

The objective of this pull request is that the pub.dev can show in the website the complete example of how to use this package, the single file example may look harder to read in an IDE but easier on the example page.

https://pub.dev/packages/percent_indicator/example

Hope it helps :)

diegoveloper commented 1 year ago

Hey, thanks for the contribution, I have a better idea, what about keeping the files as it's(because people will find easier the code when they search on the repo) but update the main file.

On the main file we could have, two examples for Circular and two for Linear, and a new button at the bottom of the screen (fixed, not scrollable, the content is scrollable), with the text "More Samples" , and that button will redirect to the current "menu" we have on the main screen.

What do you think ?

ivofernandes commented 1 year ago

Well, the package is yours so you are the one that needs to decide that trade-off :)

On my packages I put all on the example in the main.dart file, because I know that most developers will just see the code on the example webpage and will not even bother to go to github. Maybe in the future the pub.dev example page will have a file navigation, but for now, they just present the main.dart