search

diegozea / MIToS.jl

A Julia package to analyze protein sequences, structures, and evolutionary information
https://diegozea.github.io/MIToS.jl/stable/
Other
75 stars 18 forks source link

Fix minor bugs #50

Closed javieriserte closed 3 years ago

javieriserte commented 5 years ago

Hi Diego!

I made a new branch to fix some little thing in MIToS:

1) Changed 'warn' to '@warn' in many places (i think warn is not a language keyword anymore) 2) download_file function gets proxy configuration from http_proxy and https_proxy enviromental variables. 3) Added a small guick dev guide

by the way, i think you should have a 'dev' branch to add things before going to 'master'

bye

coveralls commented 5 years ago

Coverage Status

Coverage increased (+1.2%) to 86.98% when pulling 0f8ccd105a4e824d67c4f7978d4181131b89a522 on javieriserte:fix_minor_bugs into 2f9d55eda81c48a4ec0daa4435bbf8f3ff000525 on diegozea:master.

codecov[bot] commented 5 years ago

Codecov Report

Merging #50 into master will increase coverage by 2.8%. The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #50     +/-   ##
=========================================
+ Coverage   85.95%   88.75%   +2.8%     
=========================================
  Files          46       51      +5     
  Lines        2065     2464    +399     
=========================================
+ Hits         1775     2187    +412     
+ Misses        290      277     -13
Impacted Files Coverage Δ
src/Utils/GeneralUtils.jl 92.72% <0%> (+1.61%) :arrow_up:
src/Pfam/PDB.jl 91.02% <100%> (-1.04%) :arrow_down:
src/MSA/PIR.jl 93.75% <33.33%> (+1.29%) :arrow_up:
src/Utils/Read.jl 85.71% <58.33%> (-14.29%) :arrow_down:
src/MSA/Raw.jl 77.77% <0%> (-3%) :arrow_down:
src/PDB/AtomsData.jl 97.36% <0%> (-2.64%) :arrow_down:
src/Information/Externals.jl 100% <0%> (ø) :arrow_up:
src/Information/Gaps.jl 100% <0%> (ø) :arrow_up:
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f9d55e...0f8ccd1. Read the comment docs.

diegozea commented 5 years ago

Shouldn't it be HTTP_PROXY instead of http_proxy?

diegozea commented 3 years ago

Hi Javi! I am sorry for the long delay with this! I will merge it with a few changes :) Including changing the ENV variables to uppercases. So, they will be HTTP_PROXY and HTTPS_PROXY. Cheers,