search

diegozea / MIToS.jl

A Julia package to analyze protein sequences, structures, and evolutionary information
https://diegozea.github.io/MIToS.jl/stable/
Other
75 stars 18 forks source link

Replace Array{T,1} with Vector{1} #58

Closed rikhuijzer closed 3 years ago

rikhuijzer commented 3 years ago

Hi! I'm working on a linter, and saw that this repository has 12 occurrences of using

Array{T,1}

where this could be shortened to

Vector{T}

I know that it doesn't shorten the code too much, but I think that overall it does improve the readability, and that is why I open this PR :smile:

Feel free to close this PR immediately if you're not interested in this small refactoring.

By the way, the tests fail locally on

RESTful PDB Interface: Test Failed at /home/rik/git/MIT_orig/test/PDB/PDB.jl:276
  Expression: (getpdbdescription("104D"))["resolution"]

with and without applying this PR

rikhuijzer commented 3 years ago

Sorry! This is not a good refactor, I think. It is confusing since the stack trace shows Array{T,1} even after using Vector{T}. I've removed this refactor completely from the linter.

diegozea commented 3 years ago

I think the error is related to https://github.com/diegozea/MIToS.jl/issues/59 Thanks for pointing out the error and the interest in the package.