search

diegozea / MIToS.jl

A Julia package to analyze protein sequences, structures, and evolutionary information
https://diegozea.github.io/MIToS.jl/stable/
Other
75 stars 18 forks source link

Formatting -> Format #74

Closed timholy closed 5 months ago

timholy commented 6 months ago

Formatting.jl is now archived.

EDIT: This also adds [compat] bounds on stdlibs, and makes Julia 1.6 the minimum supported version.

timholy commented 6 months ago

Test failures expected from #73. Fortunately the PDB tests run before the Pfam tests.

timholy commented 6 months ago

Hmm, looks like we have to drop Julia 1.0 if we're going to do this. I've tentatively made Julia 1.6 the minimum. I've also done a minor bump, since you're supposed to when you drop support for older Julia versions.

timholy commented 5 months ago

Test failures are because Interpro throttles the number of simultaneous users. There may not be much reason to test unix/windows/mac, perhaps just one would suffice.

diegozea commented 5 months ago

Hi @timholy, thank you so much for tackling this; it was on my todo list for a while :)

Yes, making 1.6 the minimum Julia version makes sense, as it is the LTS version. I was trying to keep compatibility with older Julia versions, as the official version in my institute's cluster is 1.5. I think that old Julia versions could also be present in other academic HPC systems. However, developing such old Julia versions becomes complicated as the ecosystem evolves, so let's move on to 1.6 as the minimum.

Yes, testing the download in a single OS makes sense to avoid that problem.

timholy commented 5 months ago

as the official version in my institute's cluster is 1.5

My condolences 😆